This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: RFC: Mips option parsing patch
Daniel Jacobowitz wrote:
[snip]
> > There should also be a comment to change the file_mips_*
> > initializations back.
>
> No need. -1 is useful to mean "not set" in case some other code ever
> needs this.
IMHO it's not a good idea to keep code around because someone else
might have use for it in future. Such code tends to become cruft.
[snip]
> > This breaks e.g. -march=r8000 -mips3 -mabi=32. Hopefully nobody
> > needs it.
>
> How? Oh, wait, I see. I don't really like the NO_ABI stuff but I was
> just following what was already there. If an ABI is specified on the
> command line it behooves us to honor it.
>
> I'm willing to let -march=r8000 -mips3 -mabi=32 fall by the roadside,
> though. -march=r3000 -mips3 -mabi=32 breaks in the same way and is
> even sillier.
>
> So, comments aside, any objection?
AFAICS it's the best we can do with it.
Thiemo