This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Better (MIPS) ELF64 archive support


Nick Clifton wrote:
[snip]
> Approved but with one slight worry:
> 
> > diff -BurpN source-orig/bfd/config.bfd source/bfd/config.bfd
> > 
> > +#ifdef BFD64
> >    mips64*el-*-linux*)
> >      targ_defvec=bfd_elf32_tradlittlemips_vec
> >      targ_selvecs="bfd_elf32_tradbigmips_vec bfd_elf64_tradlittlemips_vec bfd_elf64_tradbigmips_vec"
> >      ;;
> > -  mips*el-*-linux*)
> > -    targ_defvec=bfd_elf32_tradlittlemips_vec
> > -    targ_selvecs="bfd_elf32_tradbigmips_vec bfd_elf64_tradlittlemips_vec bfd_elf64_tradbigmips_vec ecoff_little_vec ecoff_big_vec"
> > -    ;;
> >    mips64*-*-linux*)
> >      targ_defvec=bfd_elf32_tradbigmips_vec
> >      targ_selvecs="bfd_elf32_tradlittlemips_vec bfd_elf64_tradbigmips_vec bfd_elf64_tradlittlemips_vec"
> > +    ;;
> > +#endif
> > +  mips*el-*-linux*)
> > +    targ_defvec=bfd_elf32_tradlittlemips_vec
> > +    targ_selvecs="bfd_elf32_tradbigmips_vec bfd_elf64_tradlittlemips_vec bfd_elf64_tradbigmips_vec ecoff_little_vec ecoff_big_vec"
> >      ;;
> 
> You appear to be moving the mipsel-linux target outside of the BFD64
> enclosure, even though it contains vectors for 64 bit targets.  Is
> this deliberate ?  Will it actually work if bfd is not configured to
> enable 64 bit support ?

Actually I moved the mips64* definitions inside the new BFD64 define. :-)
It doesn't change anything for mipsel-linux. Maybe it should, because
the bfd_elf64* vectors won't work right without BFD64, but I don't want
to do that now.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]