This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Remove misleading readelf MIPS output


Hi Thiemo,

> 2001-12-13  Thiemo Seufer <seufer@csv.ica.uni-stuttgart.de>
> 
> 	/binutils/ChangeLog
> 	* readelf.c (get_machine_flags): Recognize header flags for ABI and
> 	ASE extensions. More robust code for ISA checking. Ignore empty fields
> 	in header flags for GNU extensions.

Approved - please apply.

> +	    /* We simply ignore the field in this case to avoid confusion:
> +	       MIPS ELF does not specify EF_MIPS_MACH, it is a GNU extension.
> +	     */

Please could you fix the comments like this.  The terminating */
should not be on a line all on its own.  Either move it to the end of
the preceeding line, or if that makes the line too long, move the last
word from the preceeding line down.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]