This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Preserve e_flags.


> 2001-12-18  H.J. Lu <hjl@gnu.org>
> 
> 	* elf-bfd.h (_bfd_elf_copy_private_bfd_data): New. Prototype.
> 	(_bfd_mips_elf_copy_private_bfd_data): Removed.
> 
> 	* elf.c (_bfd_elf_copy_private_bfd_data): New. Copy e_flags in
> 	the ELF header.
> 	* elf32-i370.c (??_elf_copy_private_bfd_data): Removed.
> 	(bfd_elf??_bfd_copy_private_bfd_data): Removed.
> 	* elf32-m32r.c: Likewise.
> 	* elf32-m68k.c: Likewise.
> 	* elf32-mcore.c: Likewise.
> 	* elf32-mips.c: Likewise.
> 	* elf32-ppc.c: Likewise.
> 	* elf32-v850.c: Likewise.
> 	* elf64-ppc.c: Likewise.
> 	* elf64-sparc.c: Likewise.
> 	* elfxx-ia64.c: Likewise.
> 
> 	* elf64-mips.c (bfd_elf64_bfd_copy_private_bfd_data): Removed.
> 
> 	* elfxx-target.h (bfd_elfNN_bfd_copy_private_bfd_data): Defined
> 	to _bfd_elf_copy_private_bfd_data.

Two comments:

(1) looks like the fn in some of the arch-specific files also copied
    GP, but that's not done in the generic version?

    Was that redundant/unnecessary, or a bug?  8-)

(2) I thought changelogs were supposed to exactly name the functions
    (etc.) being modified.  I.e. no wildcards...



chris


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]