Re: [PATCH RFA] fix generation of MIPS -membedded-pic jumps

[Eric Christopher <echristo at redhat dot com>]

> for BFD_RELOC_16_PCREL_S2, fx_pcrel is set.
> 

Oh. Right, that's and || not &&. :)

> The code isn't the simplest, i agree.
> 
> 	if (value is not zero)
> 	    and	((not pcrel) or (this particular kind of pcrel reloc))
> 
> 
> Previously, for fx_r_type == BFD_RELOC_16_PCREL_S2, this block won't
> be executed, since (not pcrel) was false.
> 
> However, for that particular type of reloc, the block needs to be
> executed.  ("or at least, it does if we want the final link to produce
> the correct output!"  8-)
> 

Right. Just makes me think that there's some other underlying problem
here.

-eric


-- 
I will not use abbrev.