This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Warnings roundup


On Sun, Feb 10, 2002 at 01:40:44PM -0500, Daniel Jacobowitz wrote:
> 
>  - coff-rs6000.c: Two uninitialized variable warnings.  They're both
>   false paths, but expecting a compiler to see that is a little too much
>   to ask, I think.  Initialized both to NULL.
> 
>  - elf32-sh.c: A signed/unsigned comparison warning. 
>   _bfd_elf_section_from_bfd_section can return -1 for failure, but
>   that's OK here, so cast appropriately.
> 
>  - trad-core.c: We cast a pointer from struct user to a bfd_vma.  I
>   silenced a warning by casting to "long" first.  It's certainly not
>   correct in the general case, but I think it's right for all targets
>   which include trad-core.
> 
> Are those OK to commit?

Yes.

> ../../branch-src/bfd/elf32-hppa.c: In function `elf32_hppa_check_relocs':
> ../../branch-src/bfd/elf32-hppa.c:1506: warning: suggest parentheses around && within ||

Ignore it.  This one is a compiler error, as the source clearly has
all the parentheses anyone could want.  Fixed in more recent versions
of gcc.

Alan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]