This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [obvious patch] fix formatting of _("...")
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: cgd at broadcom dot com
- Cc: binutils at sources dot redhat dot com, Richard dot Earnshaw at arm dot com
- Date: Mon, 11 Feb 2002 10:25:45 +0000
- Subject: Re: [obvious patch] fix formatting of _("...")
- Organization: ARM Ltd.
- Reply-to: Richard dot Earnshaw at arm dot com
It's not obvious to me that the following should be translated... These
are documented feature names, not native language text.
Not that this really makes what you did wrong, since it was like that
before.
R.
> Index: elf32-m68k.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-m68k.c,v
> retrieving revision 1.34
> diff -u -r1.34 elf32-m68k.c
> --- elf32-m68k.c 2001/12/18 17:59:58 1.34
> +++ elf32-m68k.c 2002/02/08 19:16:17
> @@ -407,10 +407,10 @@
[...]
> if (elf_elfheader (abfd)->e_flags & EF_CPU32)
> - fprintf (file, _ (" [cpu32]"));
> + fprintf (file, _(" [cpu32]"));
>
> fputc ('\n', file);
>
> Index: elf32-mips.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-mips.c,v
> retrieving revision 1.143
> diff -u -r1.143 elf32-mips.c
> --- elf32-mips.c 2002/02/06 21:34:17 1.143
> +++ elf32-mips.c 2002/02/08 19:16:18
> @@ -3280,11 +3280,11 @@
> else if ((elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_4)
> fprintf (file, _(" [mips4]"));
> else if ((elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_5)
> - fprintf (file, _ (" [mips5]"));
> + fprintf (file, _(" [mips5]"));
> else if ((elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_32)
> - fprintf (file, _ (" [mips32]"));
> + fprintf (file, _(" [mips32]"));
> else if ((elf_elfheader (abfd)->e_flags & EF_MIPS_ARCH) == E_MIPS_ARCH_64)
> - fprintf (file, _ (" [mips64]"));
> + fprintf (file, _(" [mips64]"));
> else
> fprintf (file, _(" [unknown ISA]"));
>
>