This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] allow easier overriding of ELF_DYNAMIC_INTERPRETER


Hi David,

> This is the basic patch I have to do this.  In general, does this
> look OK?

Yes, but I am a little concerned.  How is a configure time option
going to be able to override the explicit inclusion of one of these
headers ?

  >  #include "elf/cris.h"
  > +#include "elf32-cris-dyn.h"

Maybe it would be better to have a configure-created "tconfig.h"
header file (ala gcc) which then includes things like the elf/cris.h
and elf32-cris-dyn.h ?

> Are there issues with the length of the header file names?

Ideally it would be nice to have file names that are unique within the
first 8 characters in order to avoid problems with FAT16 based file
systems.  So maybe you could leave off the "elf32-" component of the
file name and just have "dyn-arm.h" "dyn-cris.h" etc.  After all there
is no real need to say "elf32" for this particular definition.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]