This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [patch/rfc] Delete floatformat_arm_ext
- From: Andrew Cagney <ac131313 at cygnus dot com>
- To: DJ Delorie <dj at delorie dot com>
- Cc: gdb-patches at sources dot redhat dot com, binutils at sources dot redhat dot com,gcc-patches at gcc dot gnu dot org
- Date: Sun, 24 Feb 2002 00:33:08 -0500
- Subject: Re: [patch/rfc] Delete floatformat_arm_ext
- References: <3C7864AB.1060900@cygnus.com> <200202240447.g1O4ldb05280@envy.delorie.com>
[I messed up a to line, original post at end]
> The attached deletes floatformat_arm_ext from include/floatformat.h and
>> libiberty/floatformat.c. As far as I know nothing uses it. GDB stopped
>> using it some time ago.
>
>
> In general, I'm opposed to changes that reduce backward compatibility.
> *How* long ago did someone actually use it? What's the chance of that
> version still being in use by someone? Are there any bad side-effects
> if we just leave it in for historical reasons?
The only useage of that floatformat that I'm aware of was removed
2001-08 by Andrew Cagney <ac131313@redhat.com>.
The single format wasn't sufficient for a program trying to correctly
manipulate both big and little endian Arm floating points - hence the
two new formats.
GDB has a strong preference for flushing code it no longer needs. It
has the unfortunate habbit of rearing its head at later inopportune moments.
enjoy,
Andrew
----------------
> Hello,
>
> The attached deletes floatformat_arm_ext from include/floatformat.h and libiberty/floatformat.c. As far as I know nothing uses it. GDB stopped using it some time ago.
>
> It has been replaced with the far more useful:
>
> const struct floatformat floatformat_arm_ext_big;
> const struct floatformat floatformat_arm_ext_littlebyte_bigword;
>
> Any comments? If not I'll commit it in a few days.
> Andrew
>
>
>
> Index: ./include/ChangeLog
> 2002-02-23 Andrew Cagney <ac131313@redhat.com>
>
> * floatformat.h (floatformat_arm_ext): Delete declaration.
>
> Index: ./libiberty/ChangeLog
> 2002-02-23 Andrew Cagney <ac131313@redhat.com>
>
> * floatformat.c (floatformat_arm_ext_big): Delete definition.
>
> Index: ./include/floatformat.h
> ===================================================================
> RCS file: /cvs/src/src/include/floatformat.h,v
> retrieving revision 1.4
> diff -u -r1.4 floatformat.h
> --- floatformat.h 2001/08/21 00:20:05 1.4
> +++ floatformat.h 2002/02/24 03:51:10
> @@ -96,7 +96,6 @@
> extern const struct floatformat floatformat_i960_ext;
> extern const struct floatformat floatformat_m88110_ext;
> extern const struct floatformat floatformat_m88110_harris_ext;
> -extern const struct floatformat floatformat_arm_ext; /* deprecated. */
> extern const struct floatformat floatformat_arm_ext_big;
> extern const struct floatformat floatformat_arm_ext_littlebyte_bigword;
> /* IA-64 Floating Point register spilt into memory. */
> Index: ./libiberty/floatformat.c
> ===================================================================
> RCS file: /cvs/src/src/libiberty/floatformat.c,v
> retrieving revision 1.5
> diff -u -r1.5 floatformat.c
> --- floatformat.c 2001/08/21 00:20:07 1.5
> +++ floatformat.c 2002/02/24 03:51:16
> @@ -103,13 +103,6 @@
> floatformat_intbit_no,
> "floatformat_m88110_ext_harris"
> };
> -const struct floatformat floatformat_arm_ext =
> -{
> - /* Bits 1 to 16 are unused. */
> - floatformat_big, 96, 0, 17, 15, 0x3fff, 0x7fff, 32, 64,
> - floatformat_intbit_yes,
> - "floatformat_arm_ext"
> -};
> const struct floatformat floatformat_arm_ext_big =
> {
> /* Bits 1 to 16 are unused. */
>