Re: [RFA] bfd/elf.c: remove #define _SYSCALL32

[Joern Rennecke <joern dot rennecke at st dot com>]

P.S.: I've just tried a native solaris 2.8 build with this
patch, and it failed.  When compiling elf.c, it is missing
the types prstatus32_t and elfcore_psinfo32_t .
The problem is that autoconf made its decisions with a test
defining _SYSCALL32, and then elf.c got compiled without that
define.  Now, for the native build, if I add -D_SYSCALL32 to
the gcc invocation, it succeeds.
Should we use a different test for _SYSCALL32 when doing a
native build?
Or should we guard the uses of _SYSCALL32 specific types
by tests of HAVE__SYSCALL32 as well as tets of the type-specific
macros?
Or should we decide early on if we are going to use _SYSCALL32,
and then define / not define it accordingly in the sys/procfs.h
type tests?


These are the setting of the sys/procfs.h types from my solaris2.8
native build config.h :


/* Define if <sys/procfs.h> has prstatus_t. */
#define HAVE_PRSTATUS_T 1

/* Define if <sys/procfs.h> has prstatus32_t. */
#define HAVE_PRSTATUS32_T 1

/* Define if <sys/procfs.h> has prstatus_t.pr_who. */
#define HAVE_PRSTATUS_T_PR_WHO 1

/* Define if <sys/procfs.h> has prstatus32_t.pr_who. */
#define HAVE_PRSTATUS32_T_PR_WHO 1

/* Define if <sys/procfs.h> has pstatus_t. */
/* #undef HAVE_PSTATUS_T */

/* Define if <sys/procfs.h> has pxstatus_t. */
/* #undef HAVE_PXSTATUS_T */

/* Define if <sys/procfs.h> has pstatus32_t. */
/* #undef HAVE_PSTATUS32_T */

/* Define if <sys/procfs.h> has prpsinfo_t. */
#define HAVE_PRPSINFO_T 1

/* Define if <sys/procfs.h> has prpsinfo32_t. */
#define HAVE_PRPSINFO32_T 1

/* Define if <sys/procfs.h> has psinfo_t. */
/* #undef HAVE_PSINFO_T */

/* Define if <sys/procfs.h> has psinfo32_t. */
/* #undef HAVE_PSINFO32_T */

/* Define if <sys/procfs.h> has lwpstatus_t. */
/* #undef HAVE_LWPSTATUS_T */

/* Define if <sys/procfs.h> has lwpxstatus_t. */
/* #undef HAVE_LWPXSTATUS_T */

/* Define if <sys/procfs.h> has lwpstatus_t.pr_context. */
/* #undef HAVE_LWPSTATUS_T_PR_CONTEXT */

/* Define if <sys/procfs.h> has lwpstatus_t.pr_reg. */
/* #undef HAVE_LWPSTATUS_T_PR_REG */

/* Define if <sys/procfs.h> has win32_pstatus_t. */
/* #undef HAVE_WIN32_PSTATUS_T */

-- 
--------------------------
SuperH
2430 Aztec West / Almondsbury / BRISTOL / BS32 4AQ
T:+44 1454 462330