This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Remove a fudge from tc-ppc.c:md_apply_fix3
- From: Geoff Keating <geoffk at geoffk dot org>
- To: amodra at bigpond dot net dot au
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 8 May 2002 00:23:41 -0700
- Subject: Re: Remove a fudge from tc-ppc.c:md_apply_fix3
- References: <20020508061653.GD3698@bubble.sa.bigpond.net.au>
- Reply-to: Geoff Keating <geoffk at redhat dot com>
The way I'd look at this patch is this:
1. Does the patch actually fix any known bug?
2. Can you write a testsuite that exercises all the code paths that
the patch affects?
If the answer to both questions is 'no', the patch is all risk and no
reward, and so there's no point committing it.
Just testing GCC and glibc is not enough. There are a bunch of other
special cases that are difficult to list. At a minimum, you need to
install the resulting glibc and run 'make check-ld' and 'make
check-gcc RUNTESTFLAGS=--target_board=unix/{,-fpic,-fPIC}'. Even that
won't cover the weirder cases.
--
- Geoffrey Keating <geoffk@geoffk.org> <geoffk@redhat.com>