This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] binutils TLS support for IA-32/IA-64
On Wed, May 22, 2002 at 05:03:05PM -0700, Richard Henderson wrote:
> On Wed, May 22, 2002 at 08:27:42PM +0200, Jakub Jelinek wrote:
> > - printf ("%s", get_dynamic_flags (entry->d_un.d_val));
> > + puts (get_dynamic_flags (entry->d_un.d_val));
>
> Surely you meant fputs, since puts adds \n.
No, I meant puts since the code was buggy before.
get_dynamic_flags doesn't add \n at the end and we really want to print next
dynamic tag on next line, see e.g.:
case DT_PLTREL:
if (do_dynamic)
puts (get_dynamic_type (entry->d_un.d_val));
break;
a few lines below in the same switch.
> > + .tdata ${RELOCATING-0} : { *(.tdata .tdata.*) }
> > + .tbss ${RELOCATING-0} : { *(.tbss .tbss.*) *(.tcommon) }
>
> We also need .gnu.linkonce.t[db].* for c++.
>
> Otherwise it looks ok.
Will do.
Jakub