This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: question about objdump output format ?


On Tue, May 28, 2002 at 01:24:24PM +0200, Ralf Habacker wrote:
>> Hi Ralf,
>>
>> > Here is the patch. It is based on the "objdump_ai_segfault_2.patch",
>> > which I have send in before.
>
>See note below
>
>> >
>> > Changelog entry for bfd dir ----------------------
>> >
>> > 2002-05-22 Ralf Habacker <ralf.habacker@freenet.de>
>> >
>> >   * peXXigen.c (pe_print_idata()): removed double printed
>> >   import table lines, added Bound-To comment.
>> >
>> > I hope, the changelog entry is clear. It may be, that the indents
>> > ate 100% pure, please correct if necessary
>>
>> Unfortunately I have some problems with this patch:
>>
>>   * It does not apply against the current sources in the CVS
>>     repository.  In fact it is not even close.  There has been some
>>     recent work on this code by Laurent Pinchart
>>     <laurent.pinchart@skynet.be> which chnages the layout for the
>>     code.
>
>This patch is based on Laurants work (peXXigen.c cvs version 1.7) and(1) on the
>patch in
>http://www.cygwin.com/ml/cygwin-apps/2002-05/msg00346.html, which fixes some
>additional seg fault fixes relating to auto-import.
>It is called "objdump_ai_segfault_2.patch" on the top of this mail and is also
>based on Laurants work.
>
>So this is the way:
>
>1. apply objdump_ai_segfault_2 patch
>
>2. apply objdump_no_double_import_table_printing patch.
>
>I have send patch (1) to binutils and cygwin-apps, but unfortunally noone has
>checked this in.

I was waiting for success reports from someone besides you.

Regardless, basic patch management would dictate that you provide
patches against plain CVS.  You shouldn't expect maintainers to apply
unrelated patches in order to check your changes in.

cgf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]