This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] objdump.c fix formatting.

Hi Hans-Peter,

On Mon, Jun 03, 2002 at 07:28:19AM -0400, Hans-Peter Nilsson wrote:
> On Mon, 3 Jun 2002, Elias Athanasopoulos wrote:
> 
> > --- objdump.c.orig	Mon Jun  3 00:04:51 2002
> > +++ objdump.c	Mon Jun  3 13:58:22 2002
> > @@ -390,11 +390,9 @@
> >    storage = bfd_get_symtab_upper_bound (abfd);
> >    if (storage < 0)
> >      bfd_fatal (bfd_get_filename (abfd));
> > -
> >    if (storage)
> 
> No, that blank line is proper formatting; it should remain.

But, we have:

  symcount = bfd_canonicalize_symtab (abfd, sy);
  if (symcount < 0)
    bfd_fatal (bfd_get_filename (abfd));
  if (symcount == 0)
    non_fatal (_("%s: no symbols"), bfd_get_filename (abfd));

I.e. no blank line between the two ifs.

Elias

-- 
http://gnewtellium.sourceforge.net			MP3 is not a crime.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]