This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: --enable-targets=all breakage
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jason R Thorpe <thorpej at wasabisystems dot com>
- Cc: <binutils at sources dot redhat dot com>
- Date: Tue, 4 Jun 2002 19:40:02 -0400 (EDT)
- Subject: Re: --enable-targets=all breakage
On Tue, 4 Jun 2002, Jason R Thorpe wrote:
> On Tue, Jun 04, 2002 at 04:07:13PM +0930, Alan Modra wrote:
>
> > Please fix.
>
> This is the "carve up elf32-sh64.c", and is similar to the patch H.J.
> posted.
>
> OK to commit?
With one mechanical change and of course with the corresponding
ChangeLog tweak, provided of course the testsuite is run with no
regressions for a cross-build to sh64-elf and that everything is
file with --enable-all-targets: Prepend those *previously
static, now global* carved-out function names with "_bfd_".
Right, the other sh64-exported functions that are for bfd-only
consumption should also have that prefix. The remaining
exported functions should perhaps have "bfd_". It'd be nice to
have those cleaned up too, but I don't ask that of you.
Thanks for doing this (and I should've thought of
--enable-targets=all at the original review; mea culpa).
brgds, H-P