This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: --enable-targets=all is broken


On Sat, Jun 08, 2002 at 11:21:02AM +0200, Andreas Jaeger wrote:
> 
> Building on i686-linux-gnu with  --enable-targets=all
> --enable-64-bit-bfd fails with:
> multiple definition of `sh64_elf64_link_output_symbol_hook'

Interesting.  To see this failure you need --enable-shared too.
Only those targets mentioned by targ_defvec= lines in config.bfd find
their way into targmatch.h, so bfd_elf64_sh64_vec isn't in
targets.c:bfd_target_match[] and elf64-sh64.o is not pulled from
libbfd.a.  --enable-targets=all is obviously not working as intended.

Easy to fix to compilation failure anyway.

	* elf64-sh64.c (sh64_elf64_link_output_symbol_hook): Make static.

Index: bfd/elf64-sh64.c
===================================================================
RCS file: /cvs/src/src/bfd/elf64-sh64.c,v
retrieving revision 1.11
diff -u -p -r1.11 elf64-sh64.c
--- bfd/elf64-sh64.c	6 Jun 2002 00:29:21 -0000	1.11
+++ bfd/elf64-sh64.c	8 Jun 2002 12:06:06 -0000
@@ -139,7 +139,7 @@ static int sh64_elf64_get_symbol_type PA
 static boolean sh64_elf64_add_symbol_hook
   PARAMS ((bfd *, struct bfd_link_info *, const Elf_Internal_Sym *,
 	   const char **, flagword *, asection **, bfd_vma *));
-extern boolean sh64_elf64_link_output_symbol_hook
+static boolean sh64_elf64_link_output_symbol_hook
   PARAMS ((bfd *, struct bfd_link_info *, const char *, Elf_Internal_Sym *,
 	   asection *));
 static boolean sh64_elf64_fake_sections
@@ -3013,7 +3013,7 @@ sh64_elf64_add_symbol_hook (abfd, info, 
    we don't need to look up and make sure to emit the main symbol for each
    DataLabel symbol.  */
 
-boolean
+static boolean
 sh64_elf64_link_output_symbol_hook (abfd, info, cname, sym, input_sec)
      bfd *abfd ATTRIBUTE_UNUSED;
      struct bfd_link_info *info;


-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]