This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] New target - Fujitsu FRV


Hi Dave,

> opcodes/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	* po/POTFILES.in: Add frv-*.[ch].
> 	* disassemble.c (ARCH_frv): New macro.
> 	(disassembler): Handle bfd_arch_frv.
> 	* configure.in: Support frv_bfd_arch.
> 	* Makefile.am (HFILES): Add frv-*.h.
> 	(CFILES): Add frv-*.c
> 	(ALL_MACHINES): Add frv-*.lo.
> 	(CLEANFILES): Add stamp-frv.
> 	(FRV_DEPS): New variable.
> 	(stamp-frv): New target.
> 	(frv-asm.lo): New target.
> 	(frv-desc.lo): New target.
> 	(frv-dis.lo): New target.
> 	(frv-ibld.lo): New target.
> 	(frv-opc.lo): New target.
> 	(frv-*.[ch]): New files.
> 
> ld/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Catherine Moore, Michael Meissner, Jim Blandy:
> 	* emulparams/elf32frv.sh: New file.
> 	* configure.tgt: Support frv-*-*.
> 	* Makefile.am (ALL_EMULATIONS): Add eelf32frv.o.
> 	(eelf32frv.c): New target.
> 
> include/elf/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Catherine Moore, Michael Meissner, Dave Brolley:
> 	* common.h (EM_CYGNUS_FRV): New macro.
> 	* frv.h: New file.
> 
> include/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Catherine Moore:
> 	* dis-asm.h (print_insn_frv): New prototype.
> 
> gas/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Catherine Moore, Michael Meissner, Richard Sandiford, Dave Brolley:
> 	* po/POTFILES.in: Add tc-frv.c, tc-frv.h.
> 	* configure.in: Support frv-*-*.
> 	* Makefile.am (CPU_TYPES): Add frv.
> 	(TARGET_CPU_CFILES): Add tc-frv.c.
> 	(TARGET_CPU_HFILES): Add tc-frv.h.
> 	(DEPTC_frv_coff): New variable.
> 	(DEPTC_frv_elf): New variable.
> 	(DEPOBJ_frv_coff): New variable.
> 	(DEPOBJ_frv_elf): New variable.
> 	(DEP_frv_coff): New variable.
> 	(DEP_frv_elf): New variable.
> 	* tc-frv.c: New file.
> 	* tc-frv.h: New file.
> 
> binutils/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Caherine Moore:
> 	* readelf.c (elf/frv.h): #include it.
> 	(guess_is_rela): Support EM_CYGNUS_FRV.
> 	(dump_relocations): Ditto.
> 	(get_machine_name): Ditto.
> 	* Makefile.am (readelf.o): add dependency on $(INCDIR)/elf/frv.h.
> 
> bfd/ChangeLog:
> 2002-06-11  Dave Brolley  <brolley@redhat.com>
> 
> 	From Catherine Moore, Michael Meissner, Dave Brolley:
> 	* po/SRC-POTFILES.in: Add cpu-frv.c and elf32-frv.c
> 	* targets.c: Support bfd_elf32_frv_vec.
> 	* reloc.c: Add FRV relocs.
> 	* configure.in: Add support for bfd-elf32-frv-vec.
> 	* config.bfd (targ_cpu): Add support for frv-*-elf.
> 	* archures.c: Add frv arch and machines.
> 	* Makefile.am (ALL_MACHINES): Add cpu-frv.lo.
> 	(ALL_MACHINES_CFILES): Add cpu-frv.c.
> 	(BFD32_BACKENDS): Add elf32-frv.lo.
> 	(BFD32_BACKENDS_CFILES): Add elf32-frv.c
> 	(cpu-frv.lo): New target.
> 	(elf32-frv.lo): New target.
> 	* cpu-frv.c: New file.
> 	* elf32-frv.c: New file.

Approved please commit - but...

> Index: bfd/configure.in
> ===================================================================
> RCS file: /cvs/src/src/bfd/configure.in,v
> retrieving revision 1.101
> diff -c -p -d -u -p -r1.101 configure.in
> --- bfd/configure.in	8 Jun 2002 23:23:08 -0000	1.101
> +++ bfd/configure.in	10 Jun 2002 22:02:38 -0000
> @@ -534,6 +534,7 @@ do
>      # This list is alphabetized to make it easy to compare
>      # with the two vector lists in targets.c.  For the same reason,
>      # use one entry per line, even though this leads to long lines.
> +    bfd_elf32_frv_vec)		tb="$tb elf32-frv.lo elf32.lo $elf" ;;
>      a29kcoff_big_vec)		tb="$tb coff-a29k.lo cofflink.lo" ;;
>      a_out_adobe_vec)		tb="$tb aout-adobe.lo aout32.lo" ;;
>      aout0_big_vec)		tb="$tb aout0.lo aout32.lo" ;;

Please keep this table alpha sorted, ie the frv entry should go
between bfd_elf32_fr30_vec and bfd_elf32_h8300_vec.

> Index: bfd/cpu-frv.c
> ===================================================================
> RCS file: bfd/cpu-frv.c
> diff -N bfd/cpu-frv.c
> --- bfd/cpu-frv.c	1 Jan 1970 00:00:00 -0000
> +++ bfd/cpu-frv.c	10 Jun 2002 22:02:38 -0000
> @@ -0,0 +1,64 @@
> +/* BFD support for the FRV processor.
> +   Copyright (C) 1999, 2000, 2001 Free Software Foundation, Inc.

Please use this year's date for the copyright notice on this and other
new files.

> Index: bfd/elf32-frv.c
>[snip]
> +/*ARGSUSED*/

ARGSUSED is now deprecated - it is not needed in source files.


One other thing - is there a GAS testsuite for the FRV ?  If so, can
this be contributed as well ?  It always helps to have a set of tests
to make sure that the assembler and disassembler are working.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]