This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [drow@mvista.com: Re: Last take: approval for MIPS_STABS_ELF killing]


Hi Daniel,

> Sorry to nag, but would you mind reviewing this patch?

No worries...

> 2002-06-11  H.J. Lu  <hjl@gnu.org>
> 	    Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* dwarf2dbg.h (dwarf2_directive_file): Return char *.
> 	* dwarf2dbg.c (dwarf2_directive_file): Return filename.
> 	* read.c (s_app_file_string): New function.
> 	(s_app_file): Call it.
> 	* read.h (s_app_file_string): Add declaration.
> 
> 2002-06-11  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* configure.in: Remove MIPS_STABS_ELF.
> 	* configure: Regenerated.
> 	* config.in: Regenerated.
> 	* config/obj-elf.h (ECOFF_DEBUGGING): Define to mips_flag_mdebug
> 	for MIPS targets.
> 	* doc/as.texinfo: Add "-mdebug" and "-no-mdebug" for MIPS.

Approved - please apply - but...

> Index: dwarf2dbg.c
> ===================================================================

> -void
> +char *
>  dwarf2_directive_file (dummy)

Please could you ammend the comment describing what this function
does and add a description of the value that it returns.

Cheers
        Nick


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]