This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH RFA] Re: Merging ELF ASE flags when linking


cgd@broadcom.com writes:
> I just looked this over again, and noticed that you didn't do anything
> similar to the last chunk of the patch quoted (i.e., the part that
> adds a gas testsuite entry to make sure that the flag is actually set
> when assembling code).

Well, no, but my patch didn't change gas.  It was a linker-only thing.

> Further, it looks like in your test you only test link compatibility,
> not that the flag is set at the end of the process.
> 
> Any reason you think the flag _shouldn't_ be checked in both places?

No, sounds like a good idea.

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]