Re: [PATCH, arm] Support for Thumb init/fini entry points

[Nick Clifton <nickc at redhat dot com>]

Hi Adam,

> Since it seems that my Thumb PLT patch has to wait until the EABI
> spec gets released, I separated the init/fini part that does not
> have any ABI implications.

> bfd/ChangeLog:
> 2002-08-12  Adam Nemet  <anemet@lnxw.com>
> 
> 	* elflink.h (elf_bfd_final_link): Allow numbers in
> 	link_info.{init,fini}_function.

I am not sure about this part of the patch.  Why should we allow
addresses to provided instead of symbol names ?  I know that it can be
done for the entry point, but I think that that was a bad idea as
well, so I would not like to see it propagated.


> ld/ChangeLog:
> 2002-08-12  Adam Nemet  <anemet@lnxw.com>
> 
> 	* emultempl/armelf.em: Include elf-bfd.h and elf/arm.h.
> 	(arm_elf_finish): Set the last bit of DT_INIT and DT_FINI
> 	depending on the type of the function.

This part of the patch is OK and I have applied it.  I made one change
- I took the common bit of code from the creation of the three symbols
and moved it into a seperate function.

Cheers
        Nick