This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] MIPS bfd: abi 64 ld -r


Stan Cox wrote:
> > I don't see how _removing_ the TYPE2/TYPE3 handling can improve things.
> 
> src[1].r_info will be a value of the form: 0x18 (R_MIPS_SUB)
> and so
> mirela.r_type2 = ELF64_MIPS_R_TYPE2 (src[1].r_info) results in 0 since
> it expands to: (((0x18) >> 8) & 0xff)

If R_MIPS_SUB is the only relocation in the relocation record this
is the way it should behave. If there are more relocations in the
record, the r_info value you are citing is wrong, which would mean
your patch fixes not the real bug but only a symptom.


Thiemo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]