Re: The current gas is broken (Re: The current binutils in CVS is broken on Linux/mips)

["H. J. Lu" <hjl at lucon dot org>]

On Mon, Sep 30, 2002 at 11:18:43AM +0930, Alan Modra wrote:
> On Sun, Sep 29, 2002 at 01:13:57PM -0700, H. J. Lu wrote:
> > It was ugly. I am afraid your patch may have broken other targets in
> > some very strange ways.
> 
> Accepted.  However, the breakage ought to be in places where target
> code hacks around reloc processing brain-damage.  The aim of my
> patch, and the bfd_install_relocation rewrite if I ever get around
> to it, is to remove all these horrible unmaintainable hacks.
> 
> See this comment in tc-mips.c
> 
>       /* This code was generated using trial and error and so is
> 	 fragile and not trustworthy.  If you change it, you should
> 	 rerun the elf-rel, elf-rel2, and empic testcases and ensure
> 	 they still pass.  */
> 

I think your patch exposed an old mips bug for BFD_RELOC_16_PCREL.
The old gas never emitted BFD_RELOC_16_PCREL relocations for defined
symbols. That is why we never saw it. The hack I posted seems to work
around the problem for me.


H.J.