This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: The current gas is broken (Re: The current binutils in CVS isbroken on Linux/mips)
On Sun, 2002-09-29 at 18:48, Alan Modra wrote:
> On Sun, Sep 29, 2002 at 01:13:57PM -0700, H. J. Lu wrote:
> > It was ugly. I am afraid your patch may have broken other targets in
> > some very strange ways.
>
> Accepted. However, the breakage ought to be in places where target
> code hacks around reloc processing brain-damage. The aim of my
> patch, and the bfd_install_relocation rewrite if I ever get around
> to it, is to remove all these horrible unmaintainable hacks.
>
> See this comment in tc-mips.c
>
> /* This code was generated using trial and error and so is
> fragile and not trustworthy. If you change it, you should
> rerun the elf-rel, elf-rel2, and empic testcases and ensure
> they still pass. */
>
> Yikes!
>
I agree. This is definitely something I need to fix and work up - I've
just not gotten a chance yet. That comment scares me.
-eric
--
Yuppies wear socks.