This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Fix gas/mips

On Sun, Sep 29, 2002 at 11:08:30PM -0700, Eric Christopher wrote:
> > 
> > 	* config/tc-mips.c (md_apply_fix3): Subtract the symbol value 
> > 	twice if howto->pcrel_offset is true.
> > 
> *groan* :) 
> 
> I need to look up Ian's mail (I think it was his mail) on why we
> subtract the addend twice on these - it _can't_ be right. 
> 
> OK for now. Please add a comment on this about subtracting the reloc
> twice and describe the situations where it comes about. 
> 
> I really gotta find time to fix this. 
> 

There are enough comments on this already. I added R_MIPS_PC16. Here
is the new patch. I will check it in shortly.


H.J.

Attachment: gas-mips.patch
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]