This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix gas/mips/vr4120.d
- From: cgd at broadcom dot com
- To: hjl at lucon dot org
- Cc: binutils at sources dot redhat dot com
- Date: 30 Sep 2002 16:36:53 -0700
- Subject: Re: PATCH: Fix gas/mips/vr4120.d
- References: <20020930140049.A4494@lucon.org><mailpost.1033419988.3181@news-sj1-1>
At Mon, 30 Sep 2002 21:06:28 +0000 (UTC), "H. J. Lu" wrote:
> FYI, I checked in the following patch to fix gas/mips/vr4120.d.
>
> 2002-09-30 H.J. Lu <hjl@gnu.org>
>
> * gas/mips/vr4120.d: Pass -m mips:4120 to objdump.
Err, uh, I don't understand, why is this change necessary?
(I don't really care, I just want to understand.)
Assuming ELF, the assemble w/ -march=vr4120 causes the 4120 'machine
type' bits to be set in the ELF header (for better or for worse).
That in turn seems to cause obdump to dump the correct disassembly,
even without the specific flag.
(This test could be seen as testing two things: disassembly, and ELF
machine type handling. You effectively removed the test for the
latter.)
(FWIW, it passes just fine on mips-linux w/o the additional flag to
objdump. Also, you changed more than that according to your patch...
8-)
cgd