This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Committed, v850: Fix v850_elf_relax_delete_bytes calls to bfd_elf32_swap_symbol_out
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: binutils at sources dot redhat dot com
- Date: Sun, 3 Nov 2002 11:45:07 +0100
- Subject: Committed, v850: Fix v850_elf_relax_delete_bytes calls to bfd_elf32_swap_symbol_out
I noticed this while checking callers of *swap_symbol_out.
Committed as obvious, after building and testing. It seems v850
linker relaxation was broken. If there had been a ld testsuite
for v850 including tests for linker relaxation, somebody would
have noticed before. If the prototype for elf_swap_symbol_out
had used correct types for cdst and shndx parameters, it may
also have been noticed. I also noticed there is no listed v850
maintainer. I also noticed I've had no coffee yet. Notice?
* elf32-v850.c (v850_elf_relax_delete_bytes): Correct parameters
for bfd_elf32_swap_symbol_out.
Index: elf32-v850.c
===================================================================
RCS file: /cvs/src/src/bfd/elf32-v850.c,v
retrieving revision 1.27
diff -u -p -r1.27 elf32-v850.c
--- elf32-v850.c 2 Sep 2002 14:23:43 -0000 1.27
+++ elf32-v850.c 3 Nov 2002 10:29:07 -0000
@@ -2388,7 +2388,7 @@ v850_elf_relax_delete_bytes (abfd, sec,
if (isym.st_value + isym.st_size >= toaddr)
isym.st_size += count;
- bfd_elf32_swap_symbol_out (abfd, & isym, shndx, esym);
+ bfd_elf32_swap_symbol_out (abfd, & isym, esym, shndx);
}
else if (isym.st_shndx == sec_shndx
&& isym.st_value < addr + count)
@@ -2401,7 +2401,7 @@ v850_elf_relax_delete_bytes (abfd, sec,
&& isym.st_value < addr + count)
isym.st_value = addr;
- bfd_elf32_swap_symbol_out (abfd, & isym, shndx, esym);
+ bfd_elf32_swap_symbol_out (abfd, & isym, esym, shndx);
}
}
@@ -2426,7 +2426,7 @@ v850_elf_relax_delete_bytes (abfd, sec,
if ((sym_hash)->root.u.def.value + isym.st_size >= toaddr)
{
isym.st_size += count;
- bfd_elf32_swap_symbol_out (abfd, & isym, shndx, esym);
+ bfd_elf32_swap_symbol_out (abfd, & isym, esym, shndx);
}
(sym_hash)->root.u.def.value -= count;
@@ -2445,7 +2445,7 @@ v850_elf_relax_delete_bytes (abfd, sec,
&& (sym_hash)->root.u.def.value < addr + count)
(sym_hash)->root.u.def.value = addr;
- bfd_elf32_swap_symbol_out (abfd, & isym, shndx, esym);
+ bfd_elf32_swap_symbol_out (abfd, & isym, esym, shndx);
}
if (shndx)
brgds, H-P