This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH/RFA]: readelf displays values of special symbol types
- From: Nick Clifton <nickc at redhat dot com>
- To: machida at sm dot sony dot co dot jp
- Cc: binutils at sources dot redhat dot com
- Date: 06 Nov 2002 18:06:26 +0000
- Subject: Re: [PATCH/RFA]: readelf displays values of special symbol types
- References: <20021104.233831.133819651.machida@sm.sony.co.jp>
Hi Hiroyuki,
> The attached patch enable READELF to display PROCESSOR-specific,
> OS-specific, reserved and unknown symbol type values.
> The attached patch is against 2002-09-05 version of READELF.
> For exsample , without this, you can't distinguish SHN_MIPS_TEXT and
> SHN_MIPS_DATA for IRIX binaries.
> * readelf.c (get_symbol_index_type): Add hex number
> to PROCESSOR-specific, OS-specific, reserved and unknown
> symbol type.
I have approved and applied this patch.
Note - I made a small change. I moved the declaration of 'buff' to
the head of the function and allowed the switch statement to exit,
which makes the code simpler and easier to read/maintain.
Note - I have decided to accept this patch without requiring a
copyright assignment. We are allowed to accept patches that are
"simple", "small" and "obvious" fixes and felt that this patch fell
into that category.
Cheers
Nick