This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Relocations in dwarf2, 2nd attempt


Hi Michal,

> Daniel Jacobowitz wrote:
> > Two problems:
> >   - You introduce long lines.
> 
> Fixed.
> 
> >   - Please add a fast-path exit from bfd_simple_get_relocated_section_contents
> >     that just calls bfd_get_section_contents if ! SEC_RELOC.
> 
> Done.
> 
> Approved?

Approved.

I made two changes.  I added a line in the ChangeLog entry describing
the patch to simple.c and I added code to that patch so that of the
call to bfd_malloc() fails, bfd_simple_get_relocated_section_contents()
will just return NULL.

Cheers
        Nick

> 2002-11-07  Michal Ludvig  <mludvig@suse.cz>
> 
> 	* dwarf2.c (read_indirect_string, read_abbrevs,	decode_line_info,
> 	_bfd_dwarf2_find_nearest_line): Use
> 	bfd_simple_get_relocated_section_contents() instead of
> 	bfd_get_section_contents().
> 	* reloc.c (bfd_perform_relocation): Add sanity check.
> 	* simple.c (simple_get_relocated_section_contents): If the section
> 	does not have any relocs associated with it, just return the
> 	unadjusted contents.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]