This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pef.c:bfd_pef_object_p breaks other targets


On Sun, Nov 10, 2002 at 11:27:53PM -0500, Klee Dienes wrote:
> I've changed pef_object_p, pef_xlib_object_p, and sym_object_p to only 
> trample abfd->tdata if the targets pass the magic-number check (in the 
> case of pef, the first 8 bytes must be "Joy!peff"; for xsym, the first 
> 32 bytes must match "\013Version 3.x" followed by 20 nulls, both of 
> which seem pretty safe).

You still have bogus assignments to abfd->tdata.  Please get rid of
them all.  On exit from xxx_object_p you should not have changed
tdata when returning NULL.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]