This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
mips assembler: relocation typo
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: binutils at sources dot redhat dot com
- Cc: cgd at broadcom dot com, scox at redhat dot com
- Date: 18 Nov 2002 18:40:28 -0200
- Subject: mips assembler: relocation typo
- Organization: GCC Team, Red Hat
Chris Demetriou pointed out this typo in gas/config/tc-mips.c a while
ago, and I hear Stan confirmed it was a typo. I had this patch in my
tree since then, and I thought I might as well go ahead and put it in
as obvious, which I'm just about to do.
Index: gas/ChangeLog
from Alexandre Oliva <aoliva@redhat.com>, Chris Demetriou <cgd@broadcom.com>
* config/tc-mips.c (tc_gen_reloc): Fix typo in handling of
GOT_LO16 on NEWABI.
Index: gas/config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.177
diff -u -p -r1.177 tc-mips.c
--- gas/config/tc-mips.c 7 Nov 2002 02:29:32 -0000 1.177
+++ gas/config/tc-mips.c 18 Nov 2002 20:39:18 -0000
@@ -13229,7 +13229,7 @@ tc_gen_reloc (section, fixp)
abort ();
/* newabi uses R_MIPS_GOT_DISP for local symbols */
- if (HAVE_NEWABI && BFD_RELOC_MIPS_GOT_LO16)
+ if (HAVE_NEWABI && fixp->fx_r_type == BFD_RELOC_MIPS_GOT_LO16)
{
fixp->fx_r_type = BFD_RELOC_MIPS_GOT_DISP;
retval[1] = NULL;
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva@{redhat.com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva@{lsd.ic.unicamp.br, gnu.org}
Free Software Evangelist Professional serial bug killer