This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add Toshiba TX49 support


Couple of comments (nitpicks really):

opcodes:

If you add T4 to G1, G2, and G3 then the only instructions you'll need
to have T4 for are dmult and dmultu.


bfd:

This looks weird. Should probably pick one :) and leave out the
underscore separating them.

        case bfd_mach_mips4400:
        case bfd_mach_mips4600:
        case bfd_mach_mips4650:
+       case bfd_mach_mips_tx49:
        case bfd_mach_mips8000:
        case bfd_mach_mips10000:
        case bfd_mach_mips12000:
Index: bfd/archures.c
===================================================================
RCS file: /cvs/src/src/bfd/archures.c,v
retrieving revision 1.58
diff -c -3 -p -r1.58 archures.c
*** bfd/archures.c      6 Nov 2002 13:26:26 -0000       1.58
--- bfd/archures.c      19 Nov 2002 14:12:27 -0000
*************** DESCRIPTION
*** 134,139 ****
--- 134,140 ----
  .#define bfd_mach_mips4400            4400
  .#define bfd_mach_mips4600            4600
  .#define bfd_mach_mips4650            4650
+ .#define bfd_mach_mips_tx4900         4900 {* Toshiba TX49 *}
  .#define bfd_mach_mips5000            5000
  .#define bfd_mach_mips5400            5400
  .#define bfd_mach_mips5500            5500


Thanks! :)

-eric

--
Yeah, I used to play basketball...


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]