This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: New Sanyo Stormy16 relocations
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 5 Dec 2002 09:26:43 +1030
- Subject: Re: New Sanyo Stormy16 relocations
- References: <1039041358.28757.307.camel@p4>
On Wed, Dec 04, 2002 at 05:35:58PM -0500, Andrew MacLeod wrote:
> * bfd/elf32-xstormy16.c (xstormy16_elf_howto): Add R_XSTORMY16_LO16
In future, please write this like
bfd/ChangeLog
* elf32-xstormy16.c ...
as the 'bfd/' shouldn't appear in the actual changelog entry.
ChangeLog entries are relative to the directory of the ChangeLog file.
> + /* Low order 16 bit value of a high memory address. */
> + HOWTO (R_XSTORMY16_LO16, /* type */
> + 0, /* rightshift */
> + 1, /* size (0 = byte, 1 = short, 2 = long) */
> + 16, /* bitsize */
> + FALSE, /* pc_relative */
> + 0, /* bitpos */
> + complain_overflow_dont, /* complain_on_overflow */
> + bfd_elf_generic_reloc, /* special_function */
> + "R_XSTORMY16_LO16", /* name */
> + FALSE, /* partial_inplace */
> + 0, /* src_mask */
> + 0xffffffff, /* dst_mask */
> + FALSE), /* pcrel_offset */
dst_mask should be 0xffff. The value you have here won't cause a
problem, but it's not strictly correct.
> + /* High order 16 bit value of a high memory address. */
> + HOWTO (R_XSTORMY16_HI16, /* type */
same here.
As far as the cgen generated files are concerned, the usual practice
is to submit a ChangeLog entry but no diff. ie.
opcodes/ChangeLog
* xstormy16-opc.c: Regenerated.
etc.
--
Alan Modra
IBM OzLabs - Linux Technology Centre