This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: PATCH : H8300 Simulator File I/O Implementation



> -----Original Message-----
> From: Kazu Hirata [mailto:kazu@cs.umass.edu]
> 
> I would split the gdb part of your patch into the opcodes part and the
> rest because opcodes is part of binutils.

Done, I am attaching three patches, One for the simulator, one for 
binutils and one for newlib.

> 
> I am guessing that you probably don't need to change the order of
> functions in newlib/libc/sys/h8300hms/syscalls.c.  You might want to
> submit a patch with few or no formatting changes to make your real
> changes exposed.  See the attached patch below.  Also, please use
> "asm (...)" instead of "asm(...)".
> 
Done that too.

> For the gdb part, I would run 'indent' to see what it recommends.  One
> thing it suggests should be to change
> 
> ! 	    filename = (char *)malloc(sizeof(char) * len);
> 
> to something like
> 
> ! 	    filename = (char *) malloc (sizeof (char) * len);
> 
> Some variables seem to be unused.
> 
Made changes as suggested by indent.

Hope to have removed all the useless variables and indentation problems.

Thanks and Regards,

Venky

Mon Dec  26 16:44:35 IST 2002  D.Venkatasubramanian
(dvenkat@noida.hcltech.com)

	* compile.c (decode): Added code for some more magic traps.
	* compile.c (sim_resume): Added support for File I/O system
	calls through callback to host_system.
	System calls provided support for :
	 open, read, write, lseek, close, stat, fstat
	Only basic support for stat and fstat.

Mon Dec  26 16:47:01 IST 2002 D.Venkatasubramanian
<dvenkat@noida.hcltech.com>

	* /libc/sys/h8300hms/syscalls.c: Support for various File I/O
	related system calls. Jump to magic vector locations, instead
	of dummy return values.
	* /libc/sys/h8300hms/read.c: Jump to magic vector location for
	supporting read system call.
	* /libc/sys/h8300hms/write.c: Jump to magic vector location for
	supporting write system call.

Mon Dec  26 16:47:09 IST 2002 D.Venkatasubramanian
<dvenkat@noida.hcltech.com>

	*h8300.h: Added some more pseudo opcodes for system call processing.



Attachment: simulator_patch.txt
Description: Text document

Attachment: newlib_patch.txt
Description: Text document

Attachment: binutils_patch.txt
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]