This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Fixes to tic3xcoff-onchip.sh filename

From: Nick Clifton <nickc at redhat dot com>
To: Svein dot Seldal at solidas dot com
Cc: binutils at sources dot redhat dot com
Date: 21 Jan 2003 17:21:44 +0000
Subject: Fixes to tic3xcoff-onchip.sh filename

Hi Svein,

  I have had to make a small change to your patch that added the file
  'emulparams/tic3xcoff-onchip.sh'.  There were three problems:

    1. ld/configure.tgt refereed to 'tic3xcoff_onchip'.  (Note the
       underscore instead of the dash).  This string is supposed to
       match the file name in the emulparams directory, minus the .sh
       extension.

    2. The convention is to use underscores not dashes in filenames.

    3. The Makefile.am target to build etic3xcoff_onchip.c generated a
       file called 'etic3xcoff.c'.

  In the future please could you check that your target still builds
  after applying your patch, but before committing it.

Cheers
        Nick

2003-01-21  Nick Clifton  <nickc@redhat.com>

	* emulparams/tic3xcoff-onchip.sh: Rename to
	* emulparams/tic3xcoff_onchip.sh: this.
	* Makefile.am (etic3xcoff_onchip.c): Fix name of generated C file.
	* Makefile.in: Regenerate.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]