This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] space register 0 changes for hppa
- From: law at redhat dot com
- To: Alan Modra <amodra at bigpond dot net dot au>
- Cc: Matthew Wilcox <willy at debian dot org>, binutils at sources dot redhat dot com, parisc-linux at parisc-linux dot org
- Date: Mon, 24 Feb 2003 08:01:31 -0700
- Subject: Re: [PATCH] space register 0 changes for hppa
- Reply-to: law at redhat dot com
In message <20030224062421 dot GA31111 at bubble dot sa dot bigpond dot net dot au>, Alan Modra writes
:
>Hi Matthew,
> ChangeLog entries shouldn't be sent as diffs. Write this one as
>
> * hppa-dis.c (print_insn_hppa <2 bit space register>): Do not print
> the space register when the value is zero.
>
>and put the reason for the change as a comment in the code if you feel
>you need some justification for the change.
>
>Did you run the binutils testsuite?
And the GDB testsuite, which tests the PA disassembler. I'm 99% sure
it's going to fail after this change.
jeff