This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: _bfd_dwarf2_find_nearest_line
- From: Alexandre Oliva <aoliva at redhat dot com>
- To: David Carlton <carlton at math dot stanford dot edu>
- Cc: binutils at sources dot redhat dot com
- Date: 15 Apr 2003 21:30:05 -0300
- Subject: Re: _bfd_dwarf2_find_nearest_line
- Organization: GCC Team, Red Hat
- References: <200304152324.h3FNOc806651@jackfruit.Stanford.EDU>
On Apr 15, 2003, David Carlton <carlton at math dot stanford dot edu> wrote:
> When compiling BFD, I got a warning about an integer->pointer
> conversion without a cast on line 1954 of dwarf2.c, which says this:
> stash-> info_ptr = 8;
> I don't know anything about BFD, but should that say '+= 8'?
Eeek... Yes, indeed. Thanks for spotting the warning and pointing
out the error. I'm going ahead and checking this in as obvious.
Index: bfd/ChangeLog
from Alexandre Oliva <aoliva at redhat dot com>
* dwarf2.c (_bfd_dwarf2_find_nearest_line): Fix typo in
2003-04-09's change.
Index: bfd/dwarf2.c
===================================================================
RCS file: /cvs/src/src/bfd/dwarf2.c,v
retrieving revision 1.48
diff -u -p -r1.48 dwarf2.c
--- bfd/dwarf2.c 9 Apr 2003 09:56:17 -0000 1.48
+++ bfd/dwarf2.c 16 Apr 2003 00:29:54 -0000
@@ -1951,7 +1951,7 @@ _bfd_dwarf2_find_nearest_line (abfd, sec
else if (addr_size == 8)
{
length = read_8_bytes (abfd, stash->info_ptr);
- stash->info_ptr = 8;
+ stash->info_ptr += 8;
}
else
stash->info_ptr += 4;
--
Alexandre Oliva Enjoy Guarana', see http://www.ic.unicamp.br/~oliva/
Red Hat GCC Developer aoliva at {redhat dot com, gcc.gnu.org}
CS PhD student at IC-Unicamp oliva at {lsd dot ic dot unicamp dot br, gnu.org}
Free Software Evangelist Professional serial bug killer