This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: PATCH: Fix the weak undefined symbols with non-defaultvisibility
Alan Modra <amodra@bigpond.net.au> writes:
> I think I may have OK'd HJ's patch a little too quickly. At least
> on powerpc, the change to elf_fix_symbol_flags to hide undef weak
> syms with non-default visibility meant that the backend tried to
> output .got relocs against a dynamic sym index of -1. Other backends
> may behave similarly, but at least this should show up when running
> the ld testsuite (if the tests aren't xfailed for some reason!).
> Also, dynamic relocs weren't being counted correctly in
> allocate_dynrelocs.
>
> This patch tidies the x86 and x86-64 code, and makes powerpc treat
> undef weaks similarly to x86.
Thanks, the patch passed the testsuite on x86-64,
Andreas
--
Andreas Jaeger
SuSE Labs aj@suse.de
private aj@arthur.inka.de
http://www.suse.de/~aj