This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] CFI directives for GAS


On Thu, 15 May 2003, Michal Ludvig wrote:
> For now the architectures that have these new directives enabled are
> i386 and amd64.
>
> Commented example on the usage can be found here:
> http://www.logix.cz/~mic/devel/gas-cfi/example.s.html
>
> How do you like this idea? Any comments? Can I apply the patch?

You asked for comments, so here goes my usual knee-jerk
reaction: Cool, but how do we know this works and doesn't
trivially break with anyone's next set of patches?  Where's the
test-suite?  Even one i386 or amd64-specific case from your
example code would be terrific.  Consider that test-cases for
new features are mandatory in GCC, and for IMHO a good reason.

brgds, H-P


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]