This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] CFI directives for GAS


Hans-Peter Nilsson told me that:
On Thu, 15 May 2003, Michal Ludvig wrote:

For now the architectures that have these new directives enabled are
i386 and amd64.

Commented example on the usage can be found here:
http://www.logix.cz/~mic/devel/gas-cfi/example.s.html

How do you like this idea? Any comments? Can I apply the patch?

You asked for comments, so here goes my usual knee-jerk reaction: Cool, but how do we know this works and doesn't trivially break with anyone's next set of patches? Where's the test-suite? Even one i386 or amd64-specific case from your example code would be terrific. Consider that test-cases for new features are mandatory in GCC, and for IMHO a good reason.

Actually I wanted to see some comments especially on the whole idea and also on the chosen method of implementation.


I know there should be a testcase and documentation, I know the code should be cleaned up, reindented and optimized. But all of these are "technical" issues.

Before I'll spend more time on it I wanted to know how do you like it from the "ideological" point of view. So ... next try? :-)

Michal Ludvig
--
* SuSE CR, s.r.o     * mludvig@suse.cz
* (+420) 296.545.373 * http://www.suse.cz


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]