This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: forwarded message from H. J. Lu
- From: "H. J. Lu" <hjl at lucon dot org>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: Alan Modra <amodra at bigpond dot net dot au>, hp at bitrange dot com,doko at cs dot tu-berlin dot de, troup at debian dot org, bug-binutils at gnu dot org,binutils at sources dot redhat dot com
- Date: Wed, 21 May 2003 10:33:49 -0700
- Subject: Re: forwarded message from H. J. Lu
- References: <20030521023247.GR3914@bubble.sa.bigpond.net.au> <200305211704.h4LH4oHE016480@hiauly1.hia.nrc.ca>
On Wed, May 21, 2003 at 01:04:50PM -0400, John David Anglin wrote:
> > We know exactly what changed.
>
> Alan, thanks for the pointer.
>
> I believe that the enclosed patch will fix the whitespace problem.
> I have removed `,' and `!' from hppa_symbol_chars. `,' is a separator
> in the opcode and operand fields. It should never be followed by
> meaningful whitespace. The same is true for `!'. When used in
> a completor, it is never the last character of the completor. It
> is also used as a statement separator. When used as a statement
> separator, there is never a label field, so there can't be any
> meaningful whitespace after it. So, as I understand it, any
> whitespace after a comma or exclamation will now be removed by the
> scrubber. This restores the previous behavior of accepting whitespace
> after commas. For other situations like `=', we don't allow whitespace
> removal. This could have been a problem for various floating point
> conditions which end in `='.
>
> I have tested this on hppa-linux, hppa2.0w-hp-hpux11.11 and
> hppa64-hp-hpux11.11. I have a gcc build running on hppa-linux
> and so far there are no problems.
>
> Does this look reasonable?
>
Please also add some testcases.
H.J.