This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: i860 tests causing all other targets to abort testsuite runs
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Richard dot Earnshaw at arm dot com, binutils at sources dot redhat dot com
- Date: Fri, 23 May 2003 12:21:21 +0100
- Subject: Re: i860 tests causing all other targets to abort testsuite runs
- Organization: ARM Ltd.
- Reply-to: Richard dot Earnshaw at arm dot com
> On Fri, 23 May 2003, Richard Earnshaw wrote:
> > The i860.exp control file was calling exit when the target wasn't an i860.
> > That causes the whole testsuite run to be abandoned -- not a good idea.
> >
> > Committed as obvious.
>
> Thanks for catching this. (Doesn't anyone study other .exp
> files when writing their own?)
Indeed.
>
> Still, a better obvious change would have been to change the
> original exit to return,
But since I *did* examine another file (the ARM one to be precise) I
copied the style there... which was why I changed it the way I did...
> and to not remove the endline at the
> end of the file.
That was an oversight.
R.