This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Use is_elf_hash_table() to check the type of a hash table in a bfd_link_info structure


On Wed, May 21, 2003 at 10:11:42AM +0100, Nick Clifton wrote:
> Hi Guys,
> 
>   I am applying the patch below to fix a bug in
>   bfd_elf_get_needed_list() exposed by running the linker test suite
>   for the i960-elf toolchain.
> 
>   Under some circumstances it is possible that the bfd_link_info
>   structure passed to this function to have a generic
>   bfd_link_hash_table structure not an elf_link_hash_table structure.
>   This is despite the fact that the creator field points to an elf
>   flavoured target.  This can cause the function to attempt to access
>   the 'needed' field of a structure that isn't there.
> 
>   A similar problem applies to the bfd_elf_get_dt_soname() function.
>   The fix is to use the is_elf_hash_table() function instead of
>   checking the hash table's creator's flavour.
> 
>   Daniel - shall I apply this patch to the branch ?

Thanks, I've taken care of it.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]