This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [Patch]: Fix a windres (rcparse.y) parsing bug for controls without text fields
- From: Ian Lance Taylor <ian at airs dot com>
- To: Danny Smith <danny_r_smith_2001 at yahoo dot co dot nz>
- Cc: binutils <binutils at sources dot redhat dot com>, Christopher Faylor <cgf at redhat dot com>
- Date: 27 Jun 2003 06:46:09 -0700
- Subject: Re: [Patch]: Fix a windres (rcparse.y) parsing bug for controls without text fields
- References: <20030627060749.6931.qmail@web21405.mail.yahoo.com>
Danny Smith <danny_r_smith_2001@yahoo.co.nz> writes:
> On further testing with MS rc.exe I am finding that, in some cases, the
> leading text field in control definition statements is not optional with
> MS rc.exe but obligatory. That is, gnu windres (before or after my proposed
> patch) accepts syntax for which rc.exe reports syntax errors. Should I
> incorporate these additional changes (to make make windres fail or warn) now
> or do that separately since those changes are orthogonal to what *this patch
> does?
Those should be separate. In fact, I'm not sure how much we need
them. It's obviously important that windres accept anything which rc
will accept--as you've discovered, this is not precisely what is
documented. However, it is not at all important that windres reject
anything which rc would reject.
Ian