Re: [PATCH] Add .set arch=FOO support to MIPS gas.

[Richard Sandiford <rsandifo at redhat dot com>]

Thiemo Seufer <ica2_ts@csv.ica.uni-stuttgart.de> writes:
> Richard Sandiford wrote:
> [snip]
> > > I tried this first, and it broke. mips_opt.isa is also needed for the
> > > -mipsX compatibility check.
> > 
> > You mean:
> > 
> > 	  /* -march takes precedence over -mipsN, since it is more descriptive.
> > 	     There's no harm in specifying both as long as the ISA levels
> > 	     are the same.  */
> > 	  if (file_mips_isa != mips_opts.isa)
> > 	    as_bad (_("-%s conflicts with the other architecture options, which imply -%s"),
> > 		    mips_cpu_info_from_isa (file_mips_isa)->name,
> > 		    mips_cpu_info_from_isa (mips_opts.isa)->name);
> > 
> > Can't you just s/mips_opts.isa/arch_info->isa/? That seems cleaner
> > to me anyway now that you're using local variables.
> 
> The updated patch does so.

Thanks, it certainly addresses my concerns.

Richard