This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [discussion/patch] use mkstemps/mkdtemps instead of mktemp.
- From: DJ Delorie <dj at delorie dot com>
- To: muthu at iqmail dot net
- Cc: binutils at sources dot redhat dot com, amodra at bigpond dot net dot au, hp at bitrange dot com, ian at airs dot com, simonb at wasabisystems dot com, berndj at prism dot co dot za, ac131313 at redhat dot com
- Date: Thu, 3 Jul 2003 18:25:44 -0400
- Subject: Re: [discussion/patch] use mkstemps/mkdtemps instead of mktemp.
- References: <Pine.LNX.4.33.0307031223450.19120-100000@Muruga.localdomain>
> 1. Added mkdtemps to libiberty. Its same as mkstemps except it uses MKDIR
> to create directory.
Logistics of the patch aside, I have a few comments:
libiberty patches must also be sent to gcc-patches@gcc.gnu.org
> /* Copyright (C) 1991, 1992, 1996, 1998 Free Software Foundation, Inc.
These years are obviously wrong.
> #if defined (_WIN32) && !defined (__CYGWIN32__)
I believe the correct symbol to test is __CYGWIN__
> Generate a unique temporary file name from @var{template}.
A unique temporary *directory* name.
> /* The file does not exist. */
file -> directory
does -> did