This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag
- From: Nick Clifton <nickc at redhat dot com>
- To: Jeff Muizelaar <muizelaar at rogers dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 11 Jul 2003 15:14:12 +0100
- Subject: Re: [PATCH] PE IMAGE_FILE_32BIT_MACHINE flag
- References: <3F0B7862.4000204@rogers.com> <3F0CB198.1060904@rogers.com>
Hi Jeff,
>> It seems all the pe's I have seen have this set and as most machines
>> that use pe's are 32 bit we should set it as well.
>>
> The attached patch does the same except inverts the #IFNDEF to make
> things a little more clear.
>
> -Jeff
> diff -urN binutils-030703/bfd/coffcode.h binutils-32bit-machine/bfd/coffcode.h
> --- binutils-030703/bfd/coffcode.h 2003-06-04 07:38:30.000000000 -0400
> +++ binutils-32bit-machine/bfd/coffcode.h 2003-07-09 20:18:49.000000000 -0400
> @@ -3873,7 +3873,9 @@
> internal_f.f_flags |= IMAGE_FILE_DEBUG_STRIPPED;
> #endif
>
> -#ifndef COFF_WITH_PE
> +#ifdef COFF_WITH_PE
> + internal_f.f_flags |= IMAGE_FILE_32BIT_MACHINE;
> +#else
> if (bfd_little_endian (abfd))
> internal_f.f_flags |= F_AR32WR;
> else
Could you supply a ChangeLog entry to go along with this patch please?
Cheers
Nick