This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] unify dynamic_symbol_p implementations


On Wed, Jul 16, 2003 at 04:47:50PM -0700, Richard Henderson wrote:
> 	* elflink.c (_bfd_elf_dynamic_symbol_p): New.
> 	* elf-bfd.h (_bfd_elf_dynamic_symbol_p): Declare it.
> 	(SYMBOL_REFERENCES_LOCAL, SYMBOL_CALLS_LOCAL): Use it.

Looks reasonable to me, except these hunks.

> @@ -3952,7 +3927,7 @@ elfNN_ia64_relocate_section (output_bfd,
>  	      /* If we don't need dynamic symbol lookup, find a
>  		 matching RELATIVE relocation.  */
>  	      dyn_r_type = r_type;
> -	      if (! local_symbol_p)
> +	      if (! dynamic_symbol_p)
>  		{
>  		  dynindx = h->dynindx;
>  		  addend = rel->r_addend;
> @@ -4300,7 +4275,7 @@ elfNN_ia64_relocate_section (output_bfd,
>  
>  	      /* If we don't need dynamic symbol lookup, install two
>  		 RELATIVE relocations.  */
> -	      if (local_symbol_p)
> +	      if (dynamic_symbol_p)
>  		{
>  		  unsigned int dyn_r_type;
>  

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]