Re: PATCH: Don't use section name to set ELF section data

["H. J. Lu" <hjl at lucon dot org>]

On Fri, Jul 25, 2003 at 09:10:18AM -0700, H. J. Lu wrote:
> On Fri, Jul 25, 2003 at 07:38:06AM -0700, H. J. Lu wrote:
> > On Fri, Jul 25, 2003 at 01:25:31PM +0100, Nick Clifton wrote:
> > > Hi H.J.
> > > 
> > > > Here is the new patch. It caused no regressions on all targets
> > > > affected. It fixed an ELF/ppc64 bug.
> > > 
> > > Excellent.
> > 
> > ...
> > 
> > > Approved - please apply.
> > > 
> > 
> > Done. I made a small change. I used
> > 
> >   if (! BFD_SEND ((B), _new_section_hook, ((B), (S)))) \
> > 
> > instead of
> > 
> >   if (!_bfd_elf_new_section_hook ((B), (S)))                  \
> >  
> 
> My patch mishandled the case:
> 
> 	.section .foo,"aw",@nobits
> 
> I checked in the following patch as an obvious fix.
> 

It is not enough. "ld -r" is broken with

	.section .foo,"aw",@nobits
	.space 20

Here is a patch.


H.J.

Attachment: binutils-type-fix.patch
Description: Text document