This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: mipsisa32-unknown-elf-as: Error: too large constant specified
On Tue, 2003-10-14 at 17:26, Ian Lance Taylor wrote:
> Eric Christopher <echristo@redhat.com> writes:
>
> > > - ep->X_add_number = (((ep->X_add_number & 0xffffffff) ^ 0x80000000)
> > > - - 0x80000000);
> > > + ep->X_add_number = (((ep->X_add_number & 0xffffffff) ^ 0x80000000)
> > > + - 0x80000000);
> > >
> >
> > Unless I'm going blind these changes appear to be whitespace?
>
> They are whitespace. The indentation was incorrect. Sorry. Here is
> a diff -b.
Well, it's good to know I'm not going blind :)
As you mentioned the behavior after your patch of handling 64-bit
sign-extended constants will be "not quite right", but we keep hitting
places where the behavior doesn't seem to be quite right. I think this
time we can err on the side of allowing some flexibility. There weren't
any regressions in your patch, however as you said, we don't really have
any testcases for this sort of thing. (You'd think 531 tests would be
sufficient...). So, if you feel comfortable with the patch then I think
it will be OK.
-eric
--
Eric Christopher <echristo@redhat.com>