This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: A gdb+bfd string pool?
- From: Joel Brobecker <brobecker at gnat dot com>
- To: David Carlton <carlton at kealia dot com>
- Cc: Andrew Cagney <ac131313 at redhat dot com>, binutils at sources dot redhat dot com,gdb at sources dot redhat dot com
- Date: Tue, 4 Nov 2003 00:16:22 -0800
- Subject: Re: A gdb+bfd string pool?
- References: <3FA27C9B.1000702@redhat.com> <yf2sml5jreg.fsf@hawaii.kealia.com>
> Personally, I'd be against this unless we have reason to believe that
> it's an important optimization. I don't like global data in general,
> even if it's only global to one component of a program, and having
> that data shared by both GDB and BFD makes me even more nervous.
> (Singleton is not my favorite design pattern.) So it sets of warning
> bells for general design reasons; our lack of const-correctness when
> dealing with names makes me even more nervous.
I have the exact same feeling.
May I recommend that, should we decide to use one, we isolate it from
GDB's code via a layer. So each module would use it's layer as if it was
not shared. It will make the move back easier, in case it's ever needed.
--
Joel